On Fri, 24 Sep 2021 17:00:47 GMT, Pavel Rappo <[email protected]> wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains four commits:
>>
>> - Simplify ToolBox.copyDir
>> Revert bad IDE suggestion
>> - Merge with upstream/master
>> - Address review comments;
>> Move `JavadocTester.copyDir` to `ToolBox`; use FileVisitor code
>> - JDK-8274172: Convert JavadocTester to use NIO
>
> test/langtools/tools/lib/toolbox/ToolBox.java line 277:
>
>> 275: if (toDir.getParent() != null) {
>> 276: Files.createDirectories(toDir.getParent());
>> 277: }
>
> This is exactly what I was going to re-suggest after I read your reply on my
> initial suggestion. We're on the same page. Thanks for simplifying this stuff.
Actually, we could simplify it to an unconditional
`Files.createDirectories(toDir.toAbsolutePath().getParent())`
-------------
PR: https://git.openjdk.java.net/jdk/pull/5644
