On Tue, 28 Sep 2021 08:23:30 GMT, Masanori Yano <my...@openjdk.org> wrote:
>> Could you please review the 8248001 bug fixes?
>>
>> The problem is that javadoc generates invalid HTML pages whose ftp:// links
>> are broken. The fix changes not to use protocol names directly, but to use
>> regular expression.
>
> Masanori Yano has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken
I updated the copyright date to 2021.
I think `checkHtml` is not necessary because `JavadocTester` checks links by
`checkLinks()`. The following is log when the fix has not been applyed.
Checked 11 files.
Found 189 references to 54 anchors in 16 files and 6 other URIs.
* 1 missing files
0 duplicate ids
0 missing ids
Schemes
1 file
1 ftp
1 http
2 https
1 mailto
Hosts
1 www.example.com
2 docs.oracle.com
1 www.exsample.com
FAILED: 1 errors found when checking links
at javadoc.tester.JavadocTester.checkLinks(JavadocTester.java:565)
at javadoc.tester.JavadocTester.javadoc(JavadocTester.java:384)
at TestHrefInDocComment.test(TestHrefInDocComment.java:46)
-------------
PR: https://git.openjdk.java.net/jdk/pull/5198
