On Mon, 4 Oct 2021 23:56:21 GMT, Jonathan Gibbons <[email protected]> wrote:

> Please review a simple test-only update, to reduce the number of locales 
> tested, and thereby reduce the number of javadoc-invocations

Looks better than it was.

The test indeed seems to use too many resources for the value it provides. 
Here's what the test reports on my machine. Before the change:

Skipped 1 locales
Tested 1015 locales

After the change:

Skipped 623 locales
Tested 393 locales

For me, the change cuts the execution time from 20 seconds to 13. While it's 
good, it is still too long to reasonably test that the locale passed as an 
argument to javax.tools.DocumentationTool#getTask reaches the doclet. BTW, is 
there a test that exercises passing the locale through the CLI?

-------------

Marked as reviewed by prappo (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5814

Reply via email to