Clarification for "these four lines". The GitHub snippet looks different from that of the javadoc-dev mailing list. Not only do the line numbers differ, but the contents differ too. Sadly, in some cases, an OpenJDK mailing list is a poor substitute for the GitHub web interface.
-Pavel > On 14 Oct 2021, at 12:13, Pavel Rappo <[email protected]> wrote: > > On Thu, 14 Oct 2021 10:12:16 GMT, Hannes Wallnöfer <[email protected]> > wrote: > >>> Please review a trivial change to have the enclosing interface/class link >>> in the class page displayed in monospace font like other similar links. >> >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove redundant cast > > This looks good. > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java > line 386: > >> 384: Content dd = new HtmlTree(TagName.DD); >> 385: dd.add(getClassLinks(HtmlLinkInfo.Kind.CLASS, >> List.of(e))); >> 386: dl.add(dd); > > You could fold these four lines into one line for consistency with similar > code in this file: > > dl.add(HtmlTree.DD(getClassLinks(HtmlLinkInfo.Kind.CLASS, List.of(e)))); > > ------------- > > Marked as reviewed by prappo (Reviewer). > > PR: https://git.openjdk.java.net/jdk/pull/5945
