> This change is mostly about tests. I say "mostly" because while increasing > code coverage, which was the primary goal of this exercise, I uncovered a few > non-critical bugs and fixed them in-place. The net effect of the change boils > down to these code coverage statistics. > > before > ------ > > %method %block %branch %line > jdk.javadoc.internal.doclets.toolkit.taglets.SnippetTaglet > 75%(12/16) > 87%(109/124) > 88%(99/112) > 85%(140/164) > > #classes %method %block %branch %line > jdk.javadoc.internal.doclets.toolkit.taglets.snippet > 70%(80/114) > 76%(310/407) > 65%(178/273) > 81%(413/508) > > after > ----- > > %method %block %branch %line > jdk.javadoc.internal.doclets.toolkit.taglets.SnippetTaglet > 100%(17/17) > 95%(120/126) > 93%(103/110) > 97%(163/168) > > %method %block %branch %line > jdk.javadoc.internal.doclets.toolkit.taglets.snippet > 83%(94/112) > 85%(348/405) > 73%(202/273) > 91%(463/505)
Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision: Address feedback - Hoist the tb (toolbox) field to SnippetTester - Use use default ctors instead of private no-arg ctors for test classes - Re-implement SnippetTester.checkOutputEither on top of JavadocTester.OutputChecker.checkAnyOf - Follow convention for jtreg comment - Improve method names with underscores ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/6359/files - new: https://git.openjdk.java.net/jdk/pull/6359/files/fd33d864..981cc305 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6359&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6359&range=01-02 Stats: 96 lines in 4 files changed: 20 ins; 37 del; 39 mod Patch: https://git.openjdk.java.net/jdk/pull/6359.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6359/head:pull/6359 PR: https://git.openjdk.java.net/jdk/pull/6359
