On Thu, 13 Jan 2022 11:29:35 GMT, Pavel Rappo <[email protected]> wrote:
>> src/java.sql/share/classes/java/sql/Statement.java line 784:
>>
>>> 782: * statement returns a {@code ResultSet} object, the second
>>> argument
>>> 783: * supplied to this method is not an
>>> 784: * {@code int} array whose elements are valid column indexes, the
>>> method is called on a
>>
>> Should it be "or the method is called on...", i.e. add the "or", otherwise
>> it's a list of problems but we don't know if they are all required, or are
>> alternatives. It probably does not mean that all these have to be true to
>> throw the exception, but it doesn't say that. We are nitpicking of course.
>
> You are right in that this `@throws` description reads a bit weird in its
> current form. That said, I wouldn't touch it in this PR for two reasons.
> Firstly, this wording seems to be consistent with other locations in that
> file. Secondly, this is a spec territory.
Yes an "or" is probably worthwhile to add.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7063
