On Fri, 13 May 2022 21:51:32 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:

> Please review a small fix to address use of snippets in source code in the 
> unnamed package.
> 
> The core of the fix is to replace `packageName(pkg, utils)` (which returns 
> `"<Unnamed>"` for the unnamed package) with plain old 
> `pkg.getQualifiedName().toString()` (which returns an empty string for the 
> unnamed package.)
> 
> There's some minor localized cleanup and rearrangement as well.
> 
> The test verifies behavior without and then with a source path, since that is 
> the likely path of discovery by a user playing with the unnamed package.

This pull request has now been integrated.

Changeset: f786e2a2
Author:    Jonathan Gibbons <j...@openjdk.org>
URL:       
https://git.openjdk.java.net/jdk/commit/f786e2a22fca7c9785b2daa5667271f418c414f4
Stats:     114 lines in 2 files changed: 102 ins; 11 del; 1 mod

8284037: Snippet-files subdirectory not automatically detected when in unnamed 
package

Reviewed-by: prappo

-------------

PR: https://git.openjdk.java.net/jdk/pull/8708

Reply via email to