On Wed, 25 May 2022 10:48:43 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains three commits: >> >> - merge with upstream master >> - fix copyright; update test description >> - JDK-8285939: javadoc java.lang.Record should not have "Direct Known >> Subclasses:" section > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/ClassTree.java > line 100: > >> 98: } >> 99: >> 100: public SortedSet<TypeElement> allSubtypes(TypeElement >> typeElement) { > > Again I think it would be nice to preserve (and update) the doc comment of > the method. I also think the naming of `subtypes` and `allSubtypes` is not > super clear, so maybe the comments should explicitly mention returning direct > or "recursive" subclasses. done ------------- PR: https://git.openjdk.java.net/jdk/pull/8523