On Tue, 15 Nov 2022 23:05:04 GMT, Christoph Langer <[email protected]> wrote:

> The new test langtools/jdk/javadoc/doclet/testValueTag/TestValueFormats.java 
> assumes a number format with a decimal separator dot (.). This can be 
> different in other locales.
> 
> This fixes the issue by expecting a number format that is calculated at 
> runtime, with the locale settings the test runs in. Not sure if it is the 
> correct way to fix, though.

Generally, there are two ways to fix issues like this:
1. force the locale to be as needed
2. accommodate the locale being used

1 is simpler; 2 seems like a better solution.

In general, we don't do a lot of testing in non-English locales. (Our bad.). Is 
this the only (javadoc?) test that fails?

-------------

PR: https://git.openjdk.org/jdk/pull/11177

Reply via email to