On Wed, 16 Nov 2022 21:07:30 GMT, ExE Boss <[email protected]> wrote: >> Jonathan Gibbons has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits since the last revision: >> >> - Address review feedback >> - Merge remote-tracking branch 'upstream/master' into >> 8290845.option-separator # Please enter a commit message to explain why this >> merge is necessary, # especially if it >> merges an updated upstream into a topic branch. # # Lines starting with >> '#' will be ignored, and an empty message aborts # the commit. >> - JDK-8290845: Consider an alternative item separator for multi-item option >> values > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/BaseConfiguration.java > line 478: > >> 476: * String.split(regex); instead, we tokenize the >> string, allowing >> 477: * special characters to be escaped with '\'. */ >> 478: List<String> tokens = tokenize(args.get(1),3); > > This should have a space: > Suggestion: > > List<String> tokens = tokenize(args.get(1), 3);
Fixed. ------------- PR: https://git.openjdk.org/jdk/pull/11178
