On Sat, 7 Jan 2023 00:42:05 GMT, Jonathan Gibbons <[email protected]> wrote:
>> You are correct. I keep forgetting about those now-deprecated-for-removal >> constructors for `java.lang.Boolean`. >> >> What you have now is good. Alternatively, you could use >> `Boolean.TRUE.equals(b)`, a Yoda condition, which you might or might not >> find aesthetically pleasing. > > Like you I believe, Yoda conditions confusing I find. There are no uses of the now-deprecated-for-removal constructors within this visitor, so the only values will be `null`, `Boolean.TRUE`, and boxed booleans. In addition, the `reduce` method on line 229 already uses `== Boolean.TRUE`. I'll update the expression. ------------- PR: https://git.openjdk.org/jdk/pull/11701
