On Mon, 13 Feb 2023 20:22:59 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
> Please review a simple change to show the correct type parameters or > arguments in the inheritance list in the class documentation header. The > solution is simply to move the implementation of > `Utils.getFirstVisibleSuperClass(...)` from the method with a `TypeElement` > parameter to the one with a `TypeMirror` parameter, thereby preserving the > type arguments. > > I compared JDK API docs with and without this change, and the only change is > that inheritance with generic superclasses is now rendered correctly. For > instance, the inheritance list for `java.util.Properties` used to look like > this: > > > java.lang.Object > java.util.Dictionary<K,V> > java.util.Hashtable<Object,Object> > java.util.Properties > > Now it is generated as follows: > > java.lang.Object > java.util.Dictionary<Object,Object> > java.util.Hashtable<Object,Object> > java.util.Properties This pull request has now been integrated. Changeset: 6d4b02b6 Author: Hannes Wallnöfer <hann...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/6d4b02b6c9b82f851b56055ba299f168618ab8ac Stats: 136 lines in 2 files changed: 119 ins; 14 del; 3 mod 8302324: Inheritance tree does not show correct type parameters/arguments Reviewed-by: prappo ------------- PR: https://git.openjdk.org/jdk/pull/12544
