On Fri, 24 Mar 2023 15:29:30 GMT, Hannes Wallnöfer <[email protected]> wrote:
> Please review a change to address accessibility issues with the > copy-to-clipboard buttons in JavaDoc-generated documentation. The most > important change is to make these button work for keyboard users, which means > buttons must exist in the DOM regardless of mouse position, be visible and > readable on keyboard focus (via tab key) and show feedback after keyboard > activation (via space or enter key). > > It also includes a few smaller improvements. The buttons for headings now > show a "Copy" label when directly hovered above, and there is a slightly more > helpful "Copy URL" or "Copy snippet" label as `aria-label` attribute. > > Incidentally I discovered that the regex pattern in > `CheckStylesheetClasses.java` did not pick up all CSS classes, so I > simplified the pattern and added a few previously undetected classes to the > test. OK, with a suggestion. 1. While "Copied!" is OK, it is not obvious what "Copy" will copy. Consider using `Copy URL` or `Copy Snippet` (or whatever else in future) when using keyboard navigating. 2. Add a Release Note for this feature, noting how to enable it when using Safari ... and any other browser-specific settings that we know of. ------------- Marked as reviewed by jjg (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13176#pullrequestreview-1367565415
