On Tue, 9 May 2023 14:01:43 GMT, Guoxiong Li <g...@openjdk.org> wrote:
> Hi all, > > When invoking the method `DocCommentParser::quotedString` with field > `newline` as `true` > and the quoted string has the character `@`, `quotedString` will break the > loop and return `null`. > This patch changes the field `newline` to `false` at the beginning of the > method `quotedString` > to solve this issue. And a corresponding test case is added. > > Thanks for the review. > > Best Regards, > -- Guoxiong Overall, I would expect `newline` to be set `false`earlier, maybe in `blockTag`, so that the setting applies to all block tags. That might still leave the possibility of a newline happening after the tag name and before the quoted string, but your test case does not cover that. ------------- PR Review: https://git.openjdk.org/jdk/pull/13888#pullrequestreview-1418759322
