On Thu, 11 May 2023 08:50:55 GMT, KIRIYAMA Takuya <[email protected]> wrote:
>> I modified the location from which javadoc copies some legal files to the >> generated documentation. If --legal-notices　option is set to default or >> nothing is specified,, GPLv2 Legal Documents are copied from >> legal/java.base/ directory, such as LICENSE, ADDITIONAL_LICENSE_INFO and >> ASSEMBLY_EXCEPTION. >> >> Would you please review this fix? > > KIRIYAMA Takuya has updated the pull request incrementally with one > additional commit since the last revision: > > 8306980: Generated docs should contain correct GPLv2 Legal Documents If you have evidence that symbolic links are being copied to the generated documentation, then the correct fix would be to ensure that any symbolic links **are** followed, and not to simulate following the links as suggested in this PR. However, I would want to see evidence that symbolic links are ending up in generated documentation before pursuing this any further. ------------- PR Comment: https://git.openjdk.org/jdk/pull/13686#issuecomment-1560144942
