On Wed, 12 Jul 2023 12:11:05 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Improve comments
>> Convert `InheritableTaglet` to just a marker interface.
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java
> line 1391:
>
>> 1389: @Override
>> 1390: protected Boolean defaultAction(DocTree node, Content
>> content) {
>> 1391: if (node instanceof InlineTagTree) {
>
> As far as I understand, the deleted `visit{DocRoot, Index, Link, Literal,
> Summary, SystemProperty}` are routed here (i.e. `defaultAction`).
>
> While I'm not against it, that `instanceof` seems unnecessary; did you add it
> for readability?
My recollection is that this was just defensive. I'll investigate.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14793#discussion_r1261441049
