On Thu, 12 Oct 2023 10:40:03 GMT, Adam Sotona <asot...@openjdk.org> wrote:
>> make/test/BuildMicrobenchmark.gmk line 99: >> >>> 97: JAVAC_FLAGS := --add-exports >>> java.base/sun.security.util=ALL-UNNAMED \ >>> 98: --add-exports java.base/sun.invoke.util=ALL-UNNAMED \ >>> 99: --add-exports java.base/jdk.internal.classfile.impl=ALL-UNNAMED >>> \ >> >> Just checking: do we really need `jdk.internal.classfile.impl`? (It might >> have been added in by someone a bit sloppily just adding all >> jdk.internal.classfile modules.) > > One of the benchmarks is focused on stack maps generator, which is not > directly exposed through the API. We can remove this one and keep just the > API-based benchmarks if it an issue. No, it is not an issue per se. If we need to benchmark internal code, that's totally fine. I just wanted to check so we did not pass unnecessary arguments. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15706#discussion_r1356638601
