On Mon, 30 Oct 2023 21:43:11 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review feedback
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDoclet.java
> line 347:
>
>> 345: case "", "default" -> {
>> 346: // use a dummy resource as a stand-in, because we
>> cannot get the URL for a resources directory
>> 347: var url =
>> HtmlDoclet.class.getResource(DocPaths.RESOURCES.resolve(DocPaths.STYLESHEET).getPath());
>
> Have you considered getting the legal notices directory from the parent of
> `resources/legal/jquery.md` instead of `resources/stylesheet.css`? Using a
> relevant file would help the reader.
Noted. Even though we may not need to copy the file to the output, we can still
always use it to find the directory.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16370#discussion_r1378135710
