On Fri, 5 Jan 2024 00:12:32 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:

> Please review a small enhancement when reporting bad options on the command 
> line.
> 
> [JDK-8313693](https://bugs.openjdk.org/browse/JDK-8313693) introduced code to 
> help determine a list of suggestions when given a misspelled word and a 
> vocabulary of possibly intended words.  It was added in the context of 
> reporting bad/invalid tags in doc comments.
> 
> This fix leverages that code by applying it to unrecognized command-line 
> options, comparing them against the set of supported command-line options. 
> Now, when an unknown command-line option is found, the code will report 
> possible suggestions, and a reference to `--help` instead of just simply 
> listing the full command-line help.

This is good. I hope that one day we introduce an improved variant of this 
functionality across most if not all JDK CLI (CC'ing @sormuras).

Please update the copyright years where you haven't already.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17274#pullrequestreview-1805705080

Reply via email to