On Fri, 26 Jan 2024 18:10:18 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains eight commits: >> >> - Merge with upstream/master >> - Merge with upstream/master >> - Merge remote-tracking branch 'upstream/master' into >> 8298405.doclet-markdown-v3 >> - Address review comments >> - Fix whitespace >> - Improve handling of embedded inline taglets >> - Customize support for Markdown headings >> - JDK-8298405: Support Markdown in Documentation Comments > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/RawHtml.java > line 145: > >> 143: } >> 144: >> 145: Pattern tag = Pattern.compile("<(?<tag>[A-Za-z0-9]+)(\\s|>)"); > > I'm not sure I grok this pattern; what's up with `\\s`? The match for a tag is one of * `<` _tag-name_ `>` * `<` _tag-name_ _whitespace_ ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16388#discussion_r1483444658