On Mon, 12 Feb 2024 17:44:29 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> refactor recent new test case in TestMarkdown.java
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java
> line 1465:
>
>> 1463: markdownInput.append('\n');
>> 1464: }
>> 1465: markdownInput.append(PLACEHOLDER_BLOCK);
>
> There's quite a lot of overlap with the recently simplified
> https://github.com/openjdk/jdk/blob/7c6316886d1ae86a663d996dae373c42281622fd/src/jdk.internal.md/share/classes/jdk/internal/markdown/MarkdownTransformer.java#L220-L238
>
> If it's impractical to factor out the common bits, maybe we could at least
> make the respective parts of HtmlDocletWriter as close as possible to those
> of MarkdownTransformer.
I think it is impractical to factor out the common bits, but I will look at the
possibility of making the code more similar -- but no promises.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16388#discussion_r1486609585
