On Mon, 12 Feb 2024 17:27:42 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:

>>> I guess it depends how much we want to import the code as-is, without 
>>> knowing any lint-warts.
>> 
>> I think it would be nice not to have to modify code beyond superficial 
>> edits: addition of headers, renaming of packages, and converting of 
>> non-ASCII symbols.
>
> I think adding `@SuppressWarnings` is a superficial edit, but I see the 
> writing on the wall.

Based on additional private conversations, and because the annotation is added 
automatically by the same utility used to address other issues in the imported 
code (package declarations, import statements, non-ASCII characters, etc), I 
will leave the annotation in at this time.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16388#discussion_r1486674245

Reply via email to