On Mon, 11 Mar 2024 13:45:19 GMT, Guoxiong Li <[email protected]> wrote:
>> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed unused methods > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlLinkFactory.java > line 31: > >> 29: import java.util.EnumSet; >> 30: import java.util.List; >> 31: import java.util.Locale; > > I can't find the code which uses `Locale`. Is it redundant? Was trying to add a visitor override for PrimitiveType and doing `primitiveType.getKind().toString().toLowerCase(Locale.ROOT)` but discovered `utils.getTypeSignature` was already doing the same; forgot to remove imports. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18179#discussion_r1519754693
