On Fri, 14 Jun 2024 12:15:45 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
>> Can I please get a review for this change, that aims to add support for >> Global HTML tags. >> Here is the >> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html) >> to the generated docs. >> Thanks in advance. > > Nizar Benalla has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains ten additional > commits since the last revision: > > - Null safety > - Merge branch 'master' into html-attributes > - remove trailing whitespace > - -Add a boolean attribute to the enum type > -Simply regex in `visitAttribute` > -Simplified the Test > -Added a negative test > - no longer print summary > - no longer print summary > - Add small comment > - Remove classpath exception > - Allow global variables src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java line 672: > 670: AttrKind kind = null; > 671: > 672: if (attr != null) { Can the remainder of this method be simplified using `Map.getOrDefault`? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1639952309
