On Thu, 11 Jul 2024 14:07:39 GMT, Pavel Rappo <[email protected]> wrote:
> Please review this jdk24 bug, which we intend to backport to jdk23 before
> RDP2, which is a week away. This is a simple fix, but it disturbs multiple
> tests.
>
> Here's a tip for reviewing. Sometimes a snippet id in a test ends up with
> `()1`, other times with `()2`. This is because the same snippet may appear
> more than once on the same page, and we are always looking for its last
> appearance. For example, if a snippet resides in the first sentence of a
> method documentation, that snippet will appear in both the "Method Summary"
> and "Method Details" sections. Otherwise, it will only appear in "Method
> Details". Appearances are numbered starting from 1 and increment by 1 from
> top ("Method Summary") to bottom ("Method Details").
This pull request has now been integrated.
Changeset: 4166e534
Author: Pavel Rappo <[email protected]>
URL:
https://git.openjdk.org/jdk/commit/4166e5345283d118d76b20de579d73bd55436ea6
Stats: 65 lines in 7 files changed: 46 ins; 0 del; 19 mod
8318106: Generated HTML for snippet does not always contain an id
Reviewed-by: liach
-------------
PR: https://git.openjdk.org/jdk/pull/20136
