On Wed, 23 Oct 2024 13:07:49 GMT, Daniel Fuchs <[email protected]> wrote:
>> test/jdk/java/net/httpclient/websocket/security/WSURLPermissionTest.java
>> line 342:
>>
>>> 340: throws Exception
>>> 341: {
>>> 342: action.run();
>>
>> testWithNoSecurityManager was previously a sanity check, the test was
>> focused on permission check. Is the test still useful to keep, maybe it
>> would be renamed or the test method renamed?
>
> Good point. Similarly, the URLPermission[] parameter is now always unused, so
> maybe I should get rid of that too.
Fixed in
https://github.com/openjdk/jdk/pull/21498/commits/82bb0d8207334d6072277e596fb16228f397fb77
and
https://github.com/openjdk/jdk/pull/21498/commits/34439751f1b26e6ff1705e35f269e260401233af
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1819119422
