On Tue, 15 Oct 2024 10:41:43 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
> Please review the removal of code in `DocCommentParser` that created an error > when encountering a spurious "@" character in an HTML attribute value after a > line break. > > The removed code (which was added in its current form in 2012) seemed to > assume that such a "@" character was part of a block tag and therefore an > indication of an unclosed attribute value. However, both line breaks and "@" > are valid characters in HTML attributes. Note that valid content for HTML > attributes in `DocCommentParser` is [text and entities as per > HTML5][html5-attributes] as well as JavaDoc inline tags, but not block tags. > > [html5-attributes]: > https://html.spec.whatwg.org/multipage/syntax.html#syntax-attribute-value > > The change adds two doctree tests, one to make sure HTML attributes with > mixed values (text, line breaks, entities, inline tags, "@") are parsed > correctly, and a second one to make sure actual unclosed attribute values are > still recognized as errors. Looks good to me. ------------- Marked as reviewed by prappo (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21520#pullrequestreview-2410110533
