On Tue, 18 Feb 2025 15:24:22 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update test with new usage message > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/resources/javadoc.properties > line 39: > >> 37: main.no-arg=Usage:\n\ >> 38: \ javadoc [options] [packagenames] [sourcefiles] [@files]\n\ >> 39: For additional help on usage: javadoc --help > > Maybe call the property `main.usage.short` to tie it to the main usage > message above and make it clear they should be kept in sync? > > The extra whitespace in the second line looks unmotivated. Could we use the > existing `main.for-more-details-see-usage` message below instead of the > second line? Fixed in [3d83cbd](https://github.com/openjdk/jdk/pull/23618/commits/3d83cbd577d4706ad408faf7df53d8a30f3482bf). The extra whitespace was indeed too much. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23618#discussion_r1963929578
