On Tue, 1 Apr 2025 16:25:58 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review of this test-only change which proposes to clean up > some issues noticed in the `TestRedirectLinks.java` test? > > The `javadoc/doclet/testLinkOption/TestRedirectLinks.java` test has been > failing intermittently in our CI. The root cause of those failures isn't yet > clear and those failures are being tracked in > https://bugs.openjdk.org/browse/JDK-8338439. > > While investigating those failures, it was noticed that this test had some > issues that could be addressed separately to rule out their role in the > intermittent failures. > > The commit in this PR updates the test to using existing test library classes > to construct the request URL as well as for constructing the SSLContext. The > test is also updated to use the correct value to represent "no response body" > when calling the `sendResponseHeaders()` method. > > The test continues to pass with this change. We will continue investigating > the intermittent failure if/when it occurs again after this change. This pull request has now been integrated. Changeset: 9bb804b1 Author: Jaikiran Pai <j...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/9bb804b14e164982860db6323c7db33214cd0d36 Stats: 99 lines in 1 file changed: 26 ins; 61 del; 12 mod 8338554: Fix inconsistencies in javadoc/doclet/testLinkOption/TestRedirectLinks.java Reviewed-by: liach, nbenalla ------------- PR: https://git.openjdk.org/jdk/pull/24359
