On Fri, 15 Aug 2025 14:05:49 GMT, SendaoYan <[email protected]> wrote:
>> Leo Korinth has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added extra timeout for:
>> jdk/internal/vm/Continuation/BasicExt.java#COMP_WINDOW_LENGTH_{1-3}-GC_AFTER_YIELD
>
> make/RunTests.gmk line 940:
>
>> 938: JTREG_AUTO_PROBLEM_LISTS :=
>> 939: # Please reach consensus before changing this. It was not easy
>> changing it to a `1`.
>> 940: JTREG_AUTO_TIMEOUT_FACTOR := 1
>
> Since the default value of JTREG_AUTO_TIMEOUT_FACTOR set to 1 by default,
> then the value of
> [JTREG_AUTO_TIMEOUT_FACTOR](https://github.com/lkorinth/jdk/blob/dbe42964371a38b2c6cd9e842c5b28ca4ac15506/make/RunTests.gmk#L944)
> when run with -Xcomp should be change from 10 to 2.5()
It is unclear to me if the author meant this to be `2.5` more than normal or
`10` more than JTREG default, or a `multiplier that seems to work`. It does not
bother me _more_ if it is a `10` then a `2.5`, as it needs to have a value that
is not the multiplicative identity value. I will not change this, the change I
have made is already large enough and I want this to be integrated ASAP.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26749#discussion_r2281781536
