On Fri, 22 Aug 2025 16:06:16 GMT, Albert Mingkun Yang <[email protected]> wrote:
>> Leo Korinth has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update testing.md, remove makefile link, fix bad text
>
> test/langtools/jdk/jshell/HangingRemoteAgent.java line 38:
>
>> 36: class HangingRemoteAgent extends RemoteExecutionControl {
>> 37:
>> 38: private static final int TIMEOUT = (int)(2000 *
>> Double.parseDouble(System.getProperty("test.timeout.factor", "1.0")));
>
> why not `Utils.TIMEOUT_FACTOR`?
There are a few places where I have changed java files that are not jtreg tests
themself. The code is used by a jtreg test, but is not the "entry" into a test.
Those files have no way to specify `@library` annotations, as no "test
annotations" are parsed. It is a pity that a jtreg "library" can not specify
dependencies to other "libraries".
> test/langtools/jdk/jshell/UITesting.java line 148:
>
>> 146: }
>> 147:
>> 148: private static final long TIMEOUT = (long) (60_000 *
>> Double.parseDouble(System.getProperty("test.timeout.factor", "1.0")));
>
> Why not `Utils.TIMEOUT_FACTOR`?
[see above](https://github.com/openjdk/jdk/pull/26749#discussion_r2297800775)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26749#discussion_r2297800775
PR Review Comment: https://git.openjdk.org/jdk/pull/26749#discussion_r2297802941
