On Tue, 9 Sep 2025 05:56:27 GMT, Pasam Soujanya <[email protected]> wrote:
>> Associating a meaningful label with every UI control allows the browser and >> assistive technology to expose and announce the control to a user. >> Associating a visible label also provides a larger clickable area. >> >> `<select id="search-modules">` should contain a label or title to describe >> it's purpose. > > Pasam Soujanya has updated the pull request incrementally with one additional > commit since the last revision: > > Form control select should have a aria-label src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties line 792: > 790: > 791: doclet.searchModules=\ > 792: Search the specified content in the modules. The change looks good regarding the code, but I'm not sure about naming/wording. I think `doclet.selectModule` and "Select the module to search in" would better describe the element. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26982#discussion_r2339863282
