On Fri, 26 Sep 2025 09:30:42 GMT, Hannes Wallnöfer <[email protected]> wrote:
>> Please review a change to fix various problems with the recently introduced >> dark theme for API docs: >> >> - Minimizes flickering when page is loaded with dark theme >> ([before](https://download.java.net/java/early_access/jdk26/docs/api/allclasses-index.html) >> / >> [after](https://cr.openjdk.org/~hannesw/8366942/api.00/allclasses-index.html)) >> - Fixes link color in table captions of inherited member summaries and >> class use pages >> ([before](https://download.java.net/java/early_access/jdk26/docs/api/java.base/java/lang/Exception.html#method-summary) >> / >> [after](https://cr.openjdk.org/~hannesw/8366942/api.00/java.base/java/lang/Exception.html#method-summary)) >> - Fixes section color in Serialized Form page >> ([before](https://download.java.net/java/early_access/jdk26/docs/api/serialized-form.html) >> / >> [after](https://cr.openjdk.org/~hannesw/8366942/api.00/serialized-form.html)) >> >> The change also includes some JS and CSS refactoring/cleanup. >> >> Generated documentation was tested on Firefox, Chrome and Safari and [can be >> viewed >> here](https://cr.openjdk.org/~hannesw/8366942/api.00/java.base/module-summary.html) >> (module java.base only). > > Hannes Wallnöfer has updated the pull request incrementally with one > additional commit since the last revision: > > Adjust table colors Code changes look good, thanks for this. It's out of scope for this change, but we may want to look at our CSS file for duplicate properties using a linter. ------------- Marked as reviewed by nbenalla (Committer). PR Review: https://git.openjdk.org/jdk/pull/27191#pullrequestreview-3284100571 PR Comment: https://git.openjdk.org/jdk/pull/27191#issuecomment-3351472497
