On Tue, 30 Sep 2025 15:26:19 GMT, Nizar Benalla <[email protected]> wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/script.js.template >> line 26: >> >>> 24: >>> 25: const sortLexicalLabel = "Sort lexicographically"; >>> 26: const sortSourceLabel = "Sort by source order"; >> >> These should be localized messages as the ones in the preceding lines. > > I avoided adding these in doclet.properties because they would be unused in > the java code and may otherwise trip `CheckResourceKeys` That should not be a problem, `CheckResourceKeys` has a mechanism to check resource use in `script.js.template`: https://github.com/openjdk/jdk/blob/master/test/langtools/jdk/javadoc/tool/CheckResourceKeys.java#L209-L220 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26322#discussion_r2394084668
