On Mon, 3 Nov 2025 16:19:27 GMT, Jan Lahoda <[email protected]> wrote:
>> `Modules.enter` completes all root modules, but in case of additional >> modules being added to the module graph via `Modules.addExtraAddModules` >> (either from javadoc, or using the `CompilationTask.addModules`, these extra >> modules may not be completed at this time. Normally, they are completed >> eventually, but if their `module-info`s contain `import module`, an NPE will >> appear while checking the import, before the complete happens. >> >> The proposal herein is to consistently complete all modules in the module >> graph when the module graphs is setup. > > Jan Lahoda has updated the pull request incrementally with one additional > commit since the last revision: > > Don't eagerly complete the unnamed module. looks sensible ------------- Marked as reviewed by vromero (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/27974#pullrequestreview-3466997830
