On Wed, 19 Nov 2025 08:56:08 GMT, Jan Lahoda <[email protected]> wrote:

>> test/langtools/tools/javac/doctree/ReferenceTest.java line 111:
>> 
>>> 109:  * {@link java.base/java.util.Map<String, String>.Entry<String, 
>>> String>.getKey Bad}
>>> 110:  * {@link java.base/java.util.Map<String, String>.Entry<String, 
>>> String>#getKey Bad}
>>> 111:  * {@link java.base/java.util.Map<String, String>.Entry<String, 
>>> String>#setValue(Object) Bad}
>> 
>> Is there a reason parameterized types don't work with modules, or is it just 
>> an implementation quirk? Not that it matters much as it is a rather unlikely 
>> corner case.
>
> To some degree, in theory, it is only an implementation quirk. In practice, 
> it is a bit tricky to make that work compatibly enough. I tried here:
> https://github.com/lahodaj/jdk/compare/JDK-8371248...lahodaj:jdk:JDK-8371248-full-attribution?expand=1
> but it is not perfect.
> 
> Unless there are objections, I would like to proceed with the change as it is 
> here, and then we can see if we can improve the reference attribution.
> 
> Thanks!

Thanks for the explanation, Jan. I'm fine with integrating this PR in its 
current form. Both module-qualified and parameterized links are so rare in real 
usage that this combination is not worth spending too much effort on.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28272#discussion_r2541630387

Reply via email to