On Wed, 6 May 2026 09:07:31 GMT, Hannes Wallnöfer <[email protected]> wrote:

>> Please review a change to improve the target highlight for javadoc member 
>> details sections.
>> 
>> Instead of highlighting the member header by changing its background color, 
>> we now add a subtle accent bar to the left side of the header. The bar is 
>> implemented as `box-shadow`, is just outside the header element and does not 
>> cause a layout shift. It uses the theme's link color with an alpha of 70%, 
>> which seems to work well in both themes. 
>> 
>> The accent bar is wide enough to be noticeable, but nowhere near as 
>> distractive as the old highlight, and brings our documentation more in line 
>> with modern documentation/UI patterns.
>> 
>> I also slightly increased the `scroll-margin-top` property of elements to 
>> position them a bit further from the navigation bar when targeted by id.
>> 
>> Sample docs for the `java.lang` package are [available 
>> here](https://cr.openjdk.org/~hannesw/8383906/api.00/java.base/java/lang/Object.html#hashCode()).
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Hannes Wallnöfer has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Increase scroll margin top for target elements

Looks good.

-------------

Marked as reviewed by nbenalla (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/31052#pullrequestreview-4439433097

Reply via email to