Good catch, Pat - the change is now in CVS.

regards

   Justin

Patrick J. McNerthney <[EMAIL PROTECTED]> wrote:
>Keepers of the JBoss:
>
>  This change should have also been included in the "findByPrimaryKey"
>method just below in the same file.
>
>  In other works, findByPrimaryKey should also through an
>ObjectNotFoundException instead of a FinderException when it does not
>find the row.
>
>Pat McNerthney
>Icicle Software, Inc.
>
>
>
>jBoss CVS Development wrote:
>> 
>>   User: forder
>>   Date: 00/08/26 12:58:20
>> 
>>   Modified:    src/main/org/jboss/ejb/plugins/jaws/jdbc
>>                         JDBCFindEntityCommand.java
>>   Log:
>>   Failure to find now throws ObjectNotFoundException.
>> 
>>   Revision  Changes    Path
>>   1.2       +3 -2      jboss/src/main/org/jboss/ejb/plugins/jaws/jdbc/JDBCFind
>EntityCommand.java
>> 
>>   Index: JDBCFindEntityCommand.java
>>   ===================================================================
>>   RCS file: /products/cvs/ejboss/jboss/src/main/org/jboss/ejb/plugins/jaws/jdb
>c/JDBCFindEntityCommand.java,v
>>   retrieving revision 1.1
>>   retrieving revision 1.2
>>   diff -u -r1.1 -r1.2
>>   --- JDBCFindEntityCommand.java        2000/08/06 02:03:51     1.1
>>   +++ JDBCFindEntityCommand.java        2000/08/26 19:58:20     1.2
>>   @@ -15,6 +15,7 @@
>>    import java.rmi.RemoteException;
>> 
>>    import javax.ejb.FinderException;
>>   +import javax.ejb.ObjectNotFoundException;
>> 
>>    import org.jboss.ejb.EntityEnterpriseContext;
>>    import org.jboss.ejb.plugins.jaws.JPMFindEntityCommand;
>>   @@ -28,7 +29,7 @@
>>     * @author <a href="mailto:[EMAIL PROTECTED]">Marc Fleury</a>
>>     * @author <a href="mailto:[EMAIL PROTECTED]">Joe Shevland</a>
>>     * @author <a href="mailto:[EMAIL PROTECTED]">Justin Forder</a>
>>   - * @version $Revision: 1.1 $
>>   + * @version $Revision: 1.2 $
>>     */
>>    public class JDBCFindEntityCommand implements JPMFindEntityCommand
>>    {
>>   @@ -64,7 +65,7 @@
>> 
>>             if (result.size() == 0)
>>             {
>>   -            throw new FinderException("No such entity!");
>>   +            throw new ObjectNotFoundException("No such entity!");
>>             } else
>>             {
>>                return result.get(0);
>> 
>> 
>>
>

-- 
Justin Forder

Reply via email to