User: fleury
Date: 00/09/26 11:34:09
Modified: src/main/org/jboss/ejb MethodInvocation.java
Log:
The tx should not be wired to teh context at this point... more management to be
done down the chain
Revision Changes Path
1.5 +17 -2 jboss/src/main/org/jboss/ejb/MethodInvocation.java
Index: MethodInvocation.java
===================================================================
RCS file: /products/cvs/ejboss/jboss/src/main/org/jboss/ejb/MethodInvocation.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- MethodInvocation.java 2000/08/18 03:20:54 1.4
+++ MethodInvocation.java 2000/09/26 18:34:09 1.5
@@ -26,7 +26,7 @@
* @see <related>
* @author Rickard �berg ([EMAIL PROTECTED])
* @author <a href="mailto:[EMAIL PROTECTED]">Marc Fleury</a>.
- * @version $Revision: 1.4 $
+ * @version $Revision: 1.5 $
*/
public class MethodInvocation
{
@@ -69,6 +69,15 @@
return args;
}
+ /*
+ * setTransaction()
+ *
+ * This method sets the transaction associated with the method
+ * Note that this doesn't mean that the transaction is associated
+ * with the thread. In fact this is the only place it exists until
+ * the TxInterceptor logic. Notably it might be the case that the
+ * tx associated here is different than the one on the target instance.
+ */
public void setTransaction(Transaction tx)
{
@@ -113,9 +122,15 @@
this.ctx = ctx;
//Set the transaction
- ctx.setTransaction(tx);
+ // MF FIXME: wrong decision. Setting the context is just an assocation
of the
+ // the Method invocation to the instance. Decisions on the
transaction association
+ // should be done elsewhere (new interceptor)
+ //ctx.setTransaction(tx);
// Set the principal
+ // MF FIXME: a warning really. The association of the context
variables (tx, principal)
+ // to the enterprise Context should not be done here but by the final
interceptor in the
+ // container, it will signify that the instance is indeed ready for
calling
ctx.setPrincipal(identity);
}
