... no need to catch and then rethrow this exception....

Index: Installer.java
===================================================================
RCS file:
/products/cvs/ejboss/jboss/src/main/org/jboss/deployment/Installer.java,v
retrieving revision 1.1
diff -r1.1 Installer.java
235,238d234
<                                               catch (IOException _ioe)
<                                               {
<                                                       throw _ioe;
<                                               }


....this private method is unused....

Index: InstallerFactory.java
===================================================================
RCS file:
/products/cvs/ejboss/jboss/src/main/org/jboss/deployment/InstallerFactory.ja
va,
retrieving revision 1.1
diff -r1.1 InstallerFactory.java
241,255d240
<       /** Truncates the the name (the last cluster of letters after the
last slash.
<        *  @param _url an URL or something like that
<        */
<       private String getName (String _url)
<       {
<               String result = _url;
<
<               if (result.endsWith ("/"))
<                       result = result.substring (0, result.length() - 1);
<
<               result = result.substring (result.lastIndexOf ("/") + 1);
<
<               return result;
<     }
<

....here's an unused local variable, and also a catch & throw exception
thingy...

Index: J2eeDeployer.java
===================================================================
RCS file:
/products/cvs/ejboss/jboss/src/main/org/jboss/deployment/J2eeDeployer.java,v
retrieving revision 1.12
diff -r1.12 J2eeDeployer.java
209,212d208
<          catch (J2eeDeploymentException _e)
<          {
<                  throw _e;
<          }
369d364
<       String message;

...and some unused local variables here...

Index: URLWizzard.java
===================================================================
RCS file:
/products/cvs/ejboss/jboss/src/main/org/jboss/deployment/URLWizzard.java,v
retrieving revision 1.6
diff -r1.6 URLWizzard.java
97,99d96
<       InputStream in;
<       OutputStream out;
<
142,144d138
<       InputStream in;
<       OutputStream out;
<
163,168d156
<
<       boolean jar = false;
<       String jarPath = "";
<       String filePath;
<       String fileName;
<       String s = _dest.toString ();

Yours,

Tom








Reply via email to