User: starksm 
  Date: 01/04/20 23:00:38

  Modified:    src/main/org/jboss/configuration ConfigurationService.java
  Log:
  Issue a warning if an mbean does not implement any of the Service interface
  methods.
  
  Revision  Changes    Path
  1.25      +6 -3      jboss/src/main/org/jboss/configuration/ConfigurationService.java
  
  Index: ConfigurationService.java
  ===================================================================
  RCS file: 
/cvsroot/jboss/jboss/src/main/org/jboss/configuration/ConfigurationService.java,v
  retrieving revision 1.24
  retrieving revision 1.25
  diff -u -r1.24 -r1.25
  --- ConfigurationService.java 2001/04/20 23:40:26     1.24
  +++ ConfigurationService.java 2001/04/21 06:00:38     1.25
  @@ -45,7 +45,7 @@
    * @author  Rickard Öberg ([EMAIL PROTECTED])
    * @author  [EMAIL PROTECTED]
    * @author  Jason Dillon <a 
href="mailto:[EMAIL PROTECTED]">&lt;[EMAIL PROTECTED]&gt;</a>
  - * @version $Revision: 1.24 $
  + * @version $Revision: 1.25 $
    */
   public class ConfigurationService
      extends ServiceMBeanSupport
  @@ -105,7 +105,6 @@
                   // get the name of the mbean 
                   ObjectName objectName = parseObjectName(mbeanElement);
                   MBeanInfo info;
  -
                   try
                   {
                       info = server.getMBeanInfo(objectName);
  @@ -427,7 +426,6 @@
                                                 loader, 
                                                 constructor.params, 
                                                 constructor.signature);
  -                        
                           info = server.getMBeanInfo(instance.getObjectName());
                        } catch (Throwable ex)
                        {
  @@ -573,6 +571,7 @@
           ServiceProxy(ObjectName objectName, MBeanOperationInfo[] opInfo)
           {
               this.objectName = objectName;
  +            int opCount = 0;
               for(int op = 0; op < opInfo.length; op ++)
               {
                   MBeanOperationInfo info = opInfo[op];
  @@ -587,7 +586,11 @@
                   if( info.getSignature().length != 0 )
                       continue;
                   hasOp[opID.intValue()] = true;
  +                opCount ++;
               }
  +            // Log a warning if the mbean does not implement any Service methods
  +            if( opCount == 0 )
  +                log.warning(objectName+" does not implement any Service methods");
           }
   
           /** Map the method name to a Service interface method index and
  
  
  

_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
http://lists.sourceforge.net/lists/listinfo/jboss-development

Reply via email to