Hi Doug, hi all,

I think I've found a bug in EntitySynchronizationInterceptor.java
in the context of the new commit option D, see the diff below.

Without the patch every bean's context is set to false in the
invoke method, effectivley rendering the commit option A to
behave as if commit option B was specified, as validContexts
with A/B/C never gets filled with anything.

I would have preferred to test behaviour before and after on my
own, before sending this to the list, but I can't run the
CVS version of JBoss just now (see my previous mail).

Would you care to check the change into CVS, if I'm right, else
would you please drop me a note, why I'm wrong (preferably
a personal note, so not blaming me too much on the list ;-)



plugins: cvs diff -u EntitySynchronizationInterceptor.java
Index: EntitySynchronizationInterceptor.java
===================================================================
RCS file:
/cvsroot/jboss/jboss/src/main/org/jboss/ejb/plugins/EntitySynchronizationInt
erceptor.java,v
retrieving revision 1.33
diff -u -r1.33 EntitySynchronizationInterceptor.java
--- EntitySynchronizationInterceptor.java       2001/06/01 07:44:52     1.33
+++ EntitySynchronizationInterceptor.java       2001/06/02 15:09:56
@@ -204,7 +204,7 @@
        Transaction tx = mi.getTransaction();

        //Commit Option D....
-       if(!validContexts.contains(ctx.getId())){
+       if((commitOption == ConfigurationMetaData.D_COMMIT_OPTION) &&
!validContexts.contains(ctx.getId())){
                   //bean isn't in cache
                   //so set valid to false so that we load...
                   ctx.setValid(false);


Thanks
Georg
 ___   ___
| + | |__    Georg Rehfeld      Woltmanstr. 12     20097 Hamburg
|_|_\ |___   [EMAIL PROTECTED]           +49 (40) 23 53 27 10



_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
http://lists.sourceforge.net/lists/listinfo/jboss-development

Reply via email to