Did you make this change to the mainline as well?

-----Original Message-----
From: Scott M Stark [mailto:[EMAIL PROTECTED]]
Sent: Wednesday, July 18, 2001 7:17 PM
To: [EMAIL PROTECTED]
Subject: Re: [JBoss-dev] jboss.jcml reading properties problem/bug.


Throwing away the new lines is not correct. The jboss.jcml file is an xml
file and it
does not have line oriented semantics. The change you propose to add in the
missing new line makes sense. I'll add it to the next beta release which
will come out tomorrow.

----- Original Message ----- 
From: "John Landers" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Wednesday, July 18, 2001 3:26 PM
Subject: [JBoss-dev] jboss.jcml reading properties problem/bug.


> I was working with jboss2.4 beta and now the code
> that reads this file strips out the cr/lf since it is using
> BufferedReader.readLine(). This works fine for most xml
> but for MBeans that use and attribute that contains multiple properties
> like this:
>   <mbean code="org.jboss.resource.ConnectionFactoryLoader"
>          name="JCA:service=ConnectionFactoryLoader,name=JmsXA">
>     <attribute name="ConnectionManagerProperties">
>       MinSize=0
>       MaxSize=10
>       Blocking=true
>       GCEnabled=false
>     </attribute>
> It becomes a string with a single line of all the properties and the
> java.util.Properties::load only gets
> a single property.
> 
> The problem is in
> org/jboss/configuration/ConfigurationService::loadConfiguration
>     public void loadConfiguration() throws Exception {
>         // The class loader used to kocal the configuration file
>         ClassLoader loader =
Thread.currentThread().getContextClassLoader();
> 
>         // Load user config from XML, and create the MBeans
>         InputStream input =
loader.getResourceAsStream(CONFIGURATION_FILE);
> 
>         StringBuffer sbufData = new StringBuffer();
>         BufferedReader br = new BufferedReader(new
> InputStreamReader(input));
> 
>         String sTmp;
> 
>         try {
>             while((sTmp = br.readLine())!=null){
>                sbufData.append(sTmp);
>             // need to append in the eol
> sbufData.append(System.getProperty("line.separator"));
>             }
>         } finally {
>             input.close();
>         }
> 
> Does this sound correct or are properties used in this fashion not
supported
> anymore?
> Maybe it is already fixed.
> 
> jcl.
> 
> _______________________________________________
> Jboss-development mailing list
> [EMAIL PROTECTED]
> http://lists.sourceforge.net/lists/listinfo/jboss-development
> 


_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
http://lists.sourceforge.net/lists/listinfo/jboss-development

_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
http://lists.sourceforge.net/lists/listinfo/jboss-development

Reply via email to