Thanks, Toby, see below. On 2001.07.25 05:36:00 -0400 Toby Allsopp wrote: > [EMAIL PROTECTED] wrote: > > > Patches item #444219, was opened at 2001-07-24 12:16 > > You can respond by visiting: > > http://sourceforge.net/tracker/?func=detail&atid=376687&aid=444219&group_id=22866 > > > > Category: JBossCX > > Group: v2.5 Rabbit Hole (unstable) > > Status: Open > > Resolution: None > > Priority: 5 > > Submitted By: David Jencks (d_jencks) > > Assigned to: Nobody/Anonymous (nobody) > > Summary: Can't add connection factories after rar > > > > Initial Comment: > > The current RARDeployer/ConnectionFactoryLoader assumes > > that the connection factories are all loaded and > > started before the RARDeployer deploys the rar's used > > by the connection factory loaders. This means you > > can't add more connection factories later. The patch > > below fixes this by implementing startService on > > ConnectionFactoryLoader to check if the needed rar has > > been deployed. If so, it immediately loads the > > connection factory, instead of waiting for rar > > deployment notification... which will never come. > > > Good point. I will apply this patch. Thanks. > > > > If requested , I will supply a test class for this change. > > > Did you really think this wouldn't be requested? :-) Please supply > this, if you'd be so kind. > Well, some of my other patches have been ignored, its hard to want to go to the effort of writing an ignored test class too ;-) This patch would be much easier to write a test case for if my previous patch was also accepted, #443701, this makes it easy to add/remove mbeans via jcml configuration mini-files. Do you thing there is any chance it will be accepted? > > > ------------------PATCH---------- > > > It's a good idea to attach the patch as a file to avoid it being > destroyed by mail clients and/or web browsers. Generally unified diffs > are preferred (diff -u). Next time... > > > >> protected void destroyService() > >> { > >> resourceAdapterName = null; > >> factoryName = null; > >> properties = null; > >> rarDeployerName = null; > >> tmName = null; > >> cmfName = null; > >> cmProps = null; > >> > >> // Principal mapping parameters > >> princMapClass = null; > >> princMapProps = null; > >> > >> rarDeployerObjectName = null; > >> > >> /** The JNDI name to which this connection factory > >> > > is bound */ > > > >> bindName = null; > >> > >> cm = null; > >> } > > > What is the purpose of this? > Do you know what destroy is conceptually supposed to do? Is there a reference explainging this? Most mbeans seem to do nothing. I think the result should be the bean can't be restarted and should be unregistered from the mbean server. Maybe this is a bad idea? > > Toby. > > > > Thanks again david jencks > _______________________________________________ > Jboss-development mailing list > [EMAIL PROTECTED] > http://lists.sourceforge.net/lists/listinfo/jboss-development > > _______________________________________________ Jboss-development mailing list [EMAIL PROTECTED] http://lists.sourceforge.net/lists/listinfo/jboss-development
