Ok
yes now I remember
1- your work is truly appreciate on the cmp2.0. It is important work
2- I didn't ok the changes to the interceptor, in fact I still DON'T
understand what is an application from your point of view. An application
is an application, in fact tx will SPAN SEVERAL COMPONENTS AND APPLICATIONS
so why you keep that outside the container in an "Application" object seems
really wrong to me... I asked you to justify the "application" I don't
remember you did and I missed the "commits". Please roll them back and work
with Bill in getting a solution to your problem that *he* approves of.
|As a side note, I was attempting to move the actual store logic out of the
|interceptor. I moved the sync entities in tx to application.
3- Ok don't do that... don't attempt to move anything out of the interceptor
on your own.
|My goal being
|to make the interceptor smaller and easier to understand.
4- don't do that, don't simplify on your own.
There is tons of work in those interceptors and more than meets the eye at
first second and third analysis that is just the nature of the beast. BTW
for 3.0 I will seriously consider going WebLogic's way and doing away with
that tx stuff and letting the DB deal with it. I screw it up everytime I
touch it and really need to get back in it deeply before I can refix it...
it takes massive concentration and energy on my part. It is really time
consuming and painful. If you don't understand something and feel the urge
to fix it...? well please don't!
|-dain
Again, the cmp work is top-notch but please don't touch the interceptors, in
fact put back the code as it was under bill supervision please. I take tons
of care everytime I touch this and still I mess it up 50% of the time the
probability space there is just mind boggling. And the last changes I did
simplify already. I will lock these classes.
Thanks
marcf
|
|----- Original Message -----
|From: "marc fleury" <[EMAIL PROTECTED]>
|To: <[EMAIL PROTECTED]>
|Sent: Tuesday, August 07, 2001 10:05 AM
|Subject: RE: [JBoss-dev] synchronizeEntitiesWithinTransaction, null pk &
|remove
|
|
|> bill,
|>
|> between you and I, this is typically the type of problem I want to avoid
|> with the core container interceptors. I know (pretty sure) I didn't miss
|> something as basic as that and obviously it wasn't you. If it is me then
|it
|> only makes the following point even more true.
|>
|> I put "you must be this tall to ride the dragon" messages in the code but
|it
|> seems to have no effect in fact it seems to attract more people
|wanting to
|> take the challenge. You and I know the nightmare that solid synch is (I
|> almost went crazy with it) so it *enfuriates* me when someone comes and
|> changes it without paying attention. Can you track down the
|change (still
|> compiling painfully in RH) and let me know and will send a "friendly
|> reminder privately". :( It could very well be me because I
|honestly don't
|> remember.
|>
|> thanks for being on top of this, I am just tired of going back
|and back to
|> it. It is a waste of our time.
|>
|> we should do it once and for all and then **lock** the 3 classes code in
|CVS
|> :)
|>
|> marcf
|>
|> |-----Original Message-----
|> |From: [EMAIL PROTECTED]
|> |[mailto:[EMAIL PROTECTED]]On Behalf Of Bill
|> |Burke
|> |Sent: Tuesday, August 07, 2001 10:34 AM
|> |To: [EMAIL PROTECTED]
|> |Subject: RE: [JBoss-dev] synchronizeEntitiesWithinTransaction, null pk &
|> |remove
|> |
|> |
|> |
|> |
|> |> -----Original Message-----
|> |> From: [EMAIL PROTECTED]
|> |> [mailto:[EMAIL PROTECTED]]On Behalf Of
|Jason
|> |> Dillon
|> |> Sent: Monday, August 06, 2001 9:19 PM
|> |> To: [EMAIL PROTECTED]
|> |> Subject: [JBoss-dev] synchronizeEntitiesWithinTransaction, null pk &
|> |> remove
|> |>
|> |>
|> |> I am running into a problem with entity bean removal where the
|> |pk is null,
|> |> which causes most everything passed (and including)
|> |> Application.synchronizeEntitiesWithinTransaction() to fail
|(called from
|> |> EntityContainer.remove()).
|> |>
|> |
|> |The person who moved synchronizeEntitiesWithinTransaction forgot to
|perform
|> |that same logic that is EntitySynchronizationInterceptor.storeEntity. I
|> |should have caught this when I reviewed the code. Sorry, I'll fix it
|now.
|> |
|> |BTW, pk get's set to null when a remove() is called.
|> |
|> |Bill
|> |
|> |
|> |
|> |_______________________________________________
|> |Jboss-development mailing list
|> |[EMAIL PROTECTED]
|> |http://lists.sourceforge.net/lists/listinfo/jboss-development
|>
|>
|> _______________________________________________
|> Jboss-development mailing list
|> [EMAIL PROTECTED]
|> http://lists.sourceforge.net/lists/listinfo/jboss-development
|>
|
|
|_______________________________________________
|Jboss-development mailing list
|[EMAIL PROTECTED]
|http://lists.sourceforge.net/lists/listinfo/jboss-development
_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
http://lists.sourceforge.net/lists/listinfo/jboss-development
