For the Minerva resource adapter jdbc wrappers, I think this is an
excellent idea.

You've replaced way more logging code than I have, I'll be happy to do it
especially if you can give me a model to copy, otherwise if you want to
that's fine too.

There is no doubt about the need to replace logging in the actual jboss
framework components with log4j also, I guess I should have done it earlier
this week.  Again - you or me?

david jencks

On 2001.08.16 21:16:51 -0400 Jason Dillon wrote:
> What are we going todo about logging from resource adapters and such?  It
> looks like there is alot of stuff that:
> 
>  if (logger != null) {
>     // some use full message
>  }
> 
> Or it will not log anything at all... even error conditions.  It also
> looks
> like there is alot of System.<out|err> usage too, which just plain sucks.
> 
> There was some email with Peter a while ago on the jms ra and logging,
> which
> we concluded that we should log4j and more or less ignore the
> javax.resource.* PrintWriter logging crap.
> 
> I have not done anything about that yet, since I have been on this bug
> hunt, which lead me to find even more cases like this.
> 
> The issues as I see them are:
> 
>  1) The current javax.resource.* logging usage of a PrintWriter sucks,
>     really, really, really sucks.
> 
>  2) Such a crappy loging mechanism is forcing folks to use adhoc logging
>     semantics, which is making it hard to debug problems when they arise.
>     Worse yet it is "hiding" problems by some code simply not logging
>     anything if it doesn't have a PrintWriter.
> 
>  3) Did I mention that PrintWriter for logging sucks... oh ya I did...
> but
>     it is so bad that I want to list it again.
> 
> I am sure there are more issues, but these suffice for the question at
> hand,
> which is what are we going to do about this?
> 
> I suggest dropping the PrintWriter <get|set>Logger() fluff (replaced by
> empty methods) and implement all logging with Log4j.  I think that this
> is the best bet in the shortterm to get a really stable and functional
> product out there.  It will limit how the ra stuff will plug into other
> servers, but we really want folks to use JBoss, not just canabalize the
> components.
> 
> Long term we want to be spec compliant, and perhaps the spec will be
> improvded with respect to logging in the next release.
> 
> My conclusion is that being spec compliant and using PrintWriters for
> logging is more harmful than anything else with respect to the rapid
> growth,
> stability and feature set of JBoss.
> 
> Let us drop it and use Log4j.
> 
> --jason
> 
> 
> _______________________________________________
> Jboss-development mailing list
> [EMAIL PROTECTED]
> http://lists.sourceforge.net/lists/listinfo/jboss-development
> 
> 

_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
http://lists.sourceforge.net/lists/listinfo/jboss-development

Reply via email to