User: mnf999 Date: 01/10/30 18:37:55 Modified: src/main/org/jboss/ejb ContainerFactory.java Log: Some Fixmes in the code, we are in a serious need of a cleanup imho... this code is starting to look green around the edge, a serious sign of decay Revision Changes Path 1.95 +8 -1 jboss/src/main/org/jboss/ejb/ContainerFactory.java Index: ContainerFactory.java =================================================================== RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/ejb/ContainerFactory.java,v retrieving revision 1.94 retrieving revision 1.95 diff -u -r1.94 -r1.95 --- ContainerFactory.java 2001/09/15 00:18:40 1.94 +++ ContainerFactory.java 2001/10/31 02:37:55 1.95 @@ -68,7 +68,7 @@ * @author <a href="mailto:[EMAIL PROTECTED]";>Peter Antman</a>. * @author <a href="mailto:[EMAIL PROTECTED]";>Scott Stark</a> * @author <a href="mailto:[EMAIL PROTECTED]";>Sacha Labourey</a> -* @version $Revision: 1.94 $ +* @version $Revision: 1.95 $ */ public class ContainerFactory extends ServiceMBeanSupport @@ -424,6 +424,8 @@ // this one dont has the contextclassloader as parent // in case of the contextclassloader has a ejb package in its // classpath the metadata of this package would be used. + // marcf: fine, just make sure that the rest of the code doesn't use this "localCL" for classes + // otherwise you are going to get runtime classcasts. ClassLoader localCl = new URLClassLoader( new URL[]{ url } ); efm.setClassLoader( localCl ); @@ -793,6 +795,10 @@ * add the indicated interceptors to the container depending on the container * transcation type and metricsEnabled flag. * + * FIXME marcf: frankly the transaction type stuff makes no sense to me, we have externalized + * the container stack construction in jbossxml and I don't see why or why there would be a + * type missmatch on the transaction + * * @param container the container instance to setup. * @param transType one of the BMT, CMT or ANY constants. * @param element the container-interceptors element from the @@ -816,6 +822,7 @@ /* Check that the interceptor is configured for the transaction mode of the bean by comparing its 'transaction' attribute to the string representation of transType + FIXME: marcf, WHY??????? */ String transAttr = ielement.getAttribute("transaction"); if( transAttr == null || transAttr.length() == 0 )
_______________________________________________ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
