User: schaefera
Date: 01/11/27 17:15:08
Modified: src/main/org/jboss/management/j2ee EJB.java EjbModule.java
J2EEApplication.java
Log:
Remove some System.out.println() and print stack traces and replaced
by logging.
Revision Changes Path
1.3 +6 -3 jboss/src/main/org/jboss/management/j2ee/EJB.java
Index: EJB.java
===================================================================
RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/management/j2ee/EJB.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- EJB.java 2001/11/28 00:40:32 1.2
+++ EJB.java 2001/11/28 01:15:08 1.3
@@ -10,6 +10,7 @@
import javax.management.MBeanServer;
import javax.management.ObjectName;
+import org.jboss.logging.Logger;
import org.jboss.metadata.BeanMetaData;
import org.jboss.metadata.SessionMetaData;
@@ -18,7 +19,7 @@
* {@link javax.management.j2ee.EJB EJB}.
*
* @author <a href="mailto:[EMAIL PROTECTED]";>Andreas Schaefer</a>.
- * @version $Revision: 1.2 $
+ * @version $Revision: 1.3 $
*
* <p><b>Revisions:</b>
*
@@ -45,6 +46,7 @@
};
public static ObjectName create( MBeanServer pServer, String pEjbModule,
BeanMetaData pBeanMeta ) {
+ Logger lLog = Logger.getLogger( EJB.class );
try {
int lType =
pBeanMeta.isSession() ?
@@ -65,18 +67,19 @@
).getObjectName();
}
catch( Exception e ) {
-// e.printStackTrace();
+ lLog.error( "Could not create JSR-77 EJB: " + pBeanMeta.getJndiName(), e );
return null;
}
}
public static void destroy( MBeanServer pServer, String pEJBName ) {
+ Logger lLog = Logger.getLogger( EJB.class );
try {
// Now remove the EJB
pServer.unregisterMBean( new ObjectName( pEJBName ) );
}
catch( Exception e ) {
-// e.printStackTrace();
+ lLog.error( "Could not destory JSR-77 EJB: " + pEJBName, e );
}
}
1.6 +12 -16 jboss/src/main/org/jboss/management/j2ee/EjbModule.java
Index: EjbModule.java
===================================================================
RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/management/j2ee/EjbModule.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- EjbModule.java 2001/11/28 00:40:32 1.5
+++ EjbModule.java 2001/11/28 01:15:08 1.6
@@ -22,12 +22,14 @@
import java.security.InvalidParameterException;
+import org.jboss.logging.Logger;
+
/**
* Root class of the JBoss JSR-77 implementation of
* {@link javax.management.j2ee.EjbModule EjbModule}.
*
* @author <a href="mailto:[EMAIL PROTECTED]";>Andreas Schaefer</a>.
- * @version $Revision: 1.5 $
+ * @version $Revision: 1.6 $
*
* <p><b>Revisions:</b>
*
@@ -51,6 +53,7 @@
// Static --------------------------------------------------------
public static ObjectName create( MBeanServer pServer, String pApplicationName,
String pName, URL pURL ) {
+ Logger lLog = Logger.getLogger( EjbModule.class );
String lDD = null;
ObjectName lApplication = null;
try {
@@ -60,7 +63,7 @@
).iterator().next();
String lServerName = lServer.getKeyPropertyList().get( "type" ) + "=" +
lServer.getKeyPropertyList().get( "name" );
- System.out.println( "EjbModule.create(), server name: " + lServerName );
+ lLog.debug( "EjbModule.create(), server name: " + lServerName );
lApplication = (ObjectName) pServer.queryNames(
new ObjectName( J2EEManagedObject.getDomainName() +
":type=J2EEApplication" +
",name=" + pApplicationName + "," + lServerName + ",*"
@@ -71,11 +74,13 @@
lDD = J2EEDeployedObject.getDeploymentDescriptor( pURL,
J2EEDeployedObject.EJB );
}
catch( Exception e ) {
- e.printStackTrace();
+ lLog.error( "Could not create JSR-77 EjbModule: " + pApplicationName, e );
+ return null;
}
try {
// Now create the J2EEApplication
- System.out.println( "Create EJB-Module, name: " + pName +
+ lLog.debug(
+ "Create EJB-Module, name: " + pName +
", application: " + lApplication +
", dd: " + lDD
);
@@ -95,28 +100,19 @@
).getObjectName();
}
catch( Exception e ) {
- e.printStackTrace();
+ lLog.error( "Could not create JSR-77 EjbModule: " + pApplicationName, e );
return null;
}
}
public static void destroy( MBeanServer pServer, String pModuleName ) {
+ Logger lLog = Logger.getLogger( EjbModule.class );
try {
-/*
- // Find the Object to be destroyed
- ObjectName lSearch = new ObjectName(
- J2EEManagedObject.getDomainName() + ":type=EJBModule,name=" + pName +
",*"
- );
- ObjectName lEjbModule = (ObjectName) pServer.queryNames(
- lSearch,
- null
- ).iterator().next();
-*/
// Now remove the EjbModule
pServer.unregisterMBean( new ObjectName( pModuleName ) );
}
catch( Exception e ) {
- e.printStackTrace();
+ lLog.error( "Could not destory JSR-77 EjbModule: " + pModuleName, e );
}
}
1.5 +9 -4 jboss/src/main/org/jboss/management/j2ee/J2EEApplication.java
Index: J2EEApplication.java
===================================================================
RCS file:
/cvsroot/jboss/jboss/src/main/org/jboss/management/j2ee/J2EEApplication.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- J2EEApplication.java 2001/11/26 21:46:51 1.4
+++ J2EEApplication.java 2001/11/28 01:15:08 1.5
@@ -17,12 +17,14 @@
import javax.management.MBeanServer;
import javax.management.ObjectName;
+import org.jboss.logging.Logger;
+
/**
* Root class of the JBoss JSR-77 implementation of
* {@link javax.management.j2ee.J2EEApplication J2EEApplication}.
*
* @author <a href="mailto:[EMAIL PROTECTED]";>Andreas Schaefer</a>.
- * @version $Revision: 1.4 $
+ * @version $Revision: 1.5 $
*
* <p><b>Revisions:</b>
*
@@ -46,6 +48,7 @@
// Static --------------------------------------------------------
public static ObjectName create( MBeanServer pServer, String pName, String
pDescriptor ) {
+ Logger lLog = Logger.getLogger( J2EEApplication.class );
String lDD = null;
ObjectName lServer = null;
try {
@@ -55,7 +58,8 @@
).iterator().next();
}
catch( Exception e ) {
- e.printStackTrace();
+ lLog.error( "Could not create JSR-77 J2EEApplication: " + pName, e );
+ return null;
}
try {
// Now create the J2EEApplication
@@ -75,12 +79,13 @@
).getObjectName();
}
catch( Exception e ) {
- e.printStackTrace();
+ lLog.error( "Could not create JSR-77 J2EEApplication: " + pName, e );
return null;
}
}
public static void destroy( MBeanServer pServer, String pName ) {
+ Logger lLog = Logger.getLogger( J2EEApplication.class );
try {
// Find the Object to be destroyed
ObjectName lSearch = new ObjectName(
@@ -94,7 +99,7 @@
pServer.unregisterMBean( lApplication );
}
catch( Exception e ) {
- e.printStackTrace();
+ lLog.error( "Could not destroy JSR-77 J2EEApplication: " + pName, e );
}
}
_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development
