User: ejort Date: 02/01/04 23:53:43 Modified: catalina/src/main/org/jboss/web/catalina/security JBossSecurityMgrRealm.java Log: Guarded debug logging Revision Changes Path 1.2 +14 -6 contrib/catalina/src/main/org/jboss/web/catalina/security/JBossSecurityMgrRealm.java Index: JBossSecurityMgrRealm.java =================================================================== RCS file: /cvsroot/jboss/contrib/catalina/src/main/org/jboss/web/catalina/security/JBossSecurityMgrRealm.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- JBossSecurityMgrRealm.java 2001/09/26 03:11:30 1.1 +++ JBossSecurityMgrRealm.java 2002/01/05 07:53:43 1.2 @@ -53,7 +53,7 @@ @see org.jboss.security.SubjectSecurityManager @author [EMAIL PROTECTED] -@version $Revision: 1.1 $ +@version $Revision: 1.2 $ */ public class JBossSecurityMgrRealm extends RealmBase implements Realm, Valve { @@ -238,6 +238,8 @@ return null; } + boolean debug = category.isDebugEnabled(); + try { // Get the JBoss security manager from the ENC context @@ -248,13 +250,15 @@ passwordChars = credentials.toCharArray(); if( securityMgr.isValid(principal, passwordChars) ) { - category.debug("User: "+username+" is authenticated"); + if (debug) + category.debug("User: "+username+" is authenticated"); SecurityAssociation.setPrincipal(principal); SecurityAssociation.setCredential(passwordChars); } else { - category.debug("User: "+username+" is NOT authenticated"); + if (debug) + category.debug("User: "+username+" is NOT authenticated"); } } catch(NamingException e) @@ -287,7 +291,9 @@ */ public boolean hasRole(Principal principal, String role) { - boolean hasRole = false; + boolean debug = category.isDebugEnabled(); + + boolean hasRole = false; try { Set requiredRoles = new HashSet(); @@ -306,11 +312,13 @@ if( hasRole ) { - category.debug("User: "+principal+" is authorized"); + if (debug) + category.debug("User: "+principal+" is authorized"); } else { - category.debug("User: "+principal+" is NOT authorized, requiredRoles="+requiredRoles); + if (debug) + category.debug("User: "+principal+" is NOT authorized, requiredRoles="+requiredRoles); } } catch(NamingException e)
_______________________________________________ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development