Patches item #513060, was opened at 2002-02-04 16:31
You can respond by visiting:
http://sourceforge.net/tracker/?func=detail&atid=376687&aid=513060&group_id=22866
Category: JBossServer
Group: v3.0 Rabbit Hole (unstable)
Status: Open
Resolution: None
Priority: 5
Submitted By: Jeff Tulley (jtulley)
Assigned to: Nobody/Anonymous (nobody)
Summary: Bug 505657 patch - ConfigurationService
Initial Comment:
Bug 505657 is that mbean elements cannot contain xml elements under attributes with
the name
"attribute", since the code does not explicitly check to make sure the <attribute>
tags it has
looked up are parented by <mbean>. This patch resolves the issue. The patch looks
big, but that
is simply because of an indent of an entire block, and the weirdness that diff -u does
trying to
resolve that. It is really a one-line fix:
if (attributeElement.getParentNode().getNodeName().equals("mbean")) {
Now, maybe the parent node could be null and this should be broken out into multiple
lines. But,
AFAICT that would only happen while building a DOM, not loading something in from
disk(which we
are not doing at the time). So, it might pay to separate this out into multiple
lines. I only fixed
the attribute problem, not the mbean or depends potential problems. (I don't see the
depends
issue, maybe I did not look hard enough)
The unified diff patch is attached.
----------------------------------------------------------------------
You can respond by visiting:
http://sourceforge.net/tracker/?func=detail&atid=376687&aid=513060&group_id=22866
_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development
